Review Request 120603: Use officially exported CMAKE paths

David Edmundson david at davidedmundson.co.uk
Wed Oct 15 23:30:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120603/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 11:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kauth


Description
-------

Use officially exported CMAKE paths

PLUGIN_INSTALL_DIR is not documented in the header of KDEInstallDirs

More importantly on builds that use KDE_INSTALL_USE_QT_SYS_PATHS this is
relative, whereas normally it's absolute.

By using the CMAKE_INSTALL_FULL path we avoid that problem as it goes
through the define_relatve define_absolute macros.


Diffs
-----

  src/BackendsConfig.h.cmake 9b82fb8 

Diff: https://git.reviewboard.kde.org/r/120603/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141015/c5f3a80f/attachment.html>


More information about the Kde-frameworks-devel mailing list