Review Request 121103: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils
Daniel Vrátil
dvratil at redhat.com
Tue Nov 11 13:28:02 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121103/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 2:27 p.m.)
Status
------
This change has been discarded.
Review request for KDE Frameworks.
Repository: kcodecs
Description
-------
This class can be very useful to many applications that need to deal with email
address validation, and so it should not be hidden somewhere in PIM, but
should be available in some more visibile framework. Also I need to kill the
KPimUtils framework, and we don't really have any better-fitting framework
available at this moment :)
Diffs
-----
src/kcodecsbase64.cpp PRE-CREATION
src/kcodecsidentity.h PRE-CREATION
src/kcodecsidentity.cpp PRE-CREATION
src/kcodecsqp.h PRE-CREATION
src/kcodecsqp.cpp PRE-CREATION
src/kcodecsuuencode.h PRE-CREATION
src/kcodecsuuencode.cpp PRE-CREATION
src/kemailaddress.h PRE-CREATION
src/kemailaddress.cpp PRE-CREATION
src/CMakeLists.txt adc0f2ab8706cd120041df0ef97ca19cb3aa9315
src/kcodecs.h 48effbbe9cb26586c94c4d1492604345c0e1ca0b
src/kcodecs.cpp 4fd660d28b6db98bc63140ca6e9852947481c6f0
src/kcodecsbase64.h PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/null-encode PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/null-encode.expected PRE-CREATION
autotests/data/codec_x-uuencode/basic-decode.x-uuencode PRE-CREATION
autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected PRE-CREATION
autotests/kcodecstest.h PRE-CREATION
autotests/kcodecstest.cpp PRE-CREATION
autotests/kemailaddresstest.h PRE-CREATION
autotests/kemailaddresstest.cpp PRE-CREATION
autotests/rfc2047test.h PRE-CREATION
autotests/rfc2047test.cpp PRE-CREATION
autotests/CMakeLists.txt 4c41ba20809d063d6fe2a17833f87fd89df538e5
autotests/base64benchmark.cpp PRE-CREATION
autotests/codectest.h PRE-CREATION
autotests/codectest.cpp PRE-CREATION
autotests/data/codec_b/basic-decode.b PRE-CREATION
autotests/data/codec_b/basic-decode.b.expected PRE-CREATION
autotests/data/codec_b/basic-encode PRE-CREATION
autotests/data/codec_b/basic-encode.expected PRE-CREATION
autotests/data/codec_b/null-decode.b PRE-CREATION
autotests/data/codec_b/null-decode.b.expected PRE-CREATION
autotests/data/codec_b/null-encode PRE-CREATION
autotests/data/codec_b/null-encode.expected PRE-CREATION
autotests/data/codec_b/padding0-encode PRE-CREATION
autotests/data/codec_b/padding0-encode.expected PRE-CREATION
autotests/data/codec_b/padding1-encode PRE-CREATION
autotests/data/codec_b/padding1-encode.expected PRE-CREATION
autotests/data/codec_b/padding2-encode PRE-CREATION
autotests/data/codec_b/padding2-encode.expected PRE-CREATION
autotests/data/codec_base64/basic-decode.base64 PRE-CREATION
autotests/data/codec_base64/basic-decode.base64.expected PRE-CREATION
autotests/data/codec_base64/basic-encode PRE-CREATION
autotests/data/codec_base64/basic-encode.expected PRE-CREATION
autotests/data/codec_base64/corrupt.base64 PRE-CREATION
autotests/data/codec_base64/corrupt.base64.expected PRE-CREATION
autotests/data/codec_base64/very_small-encode PRE-CREATION
autotests/data/codec_base64/very_small-encode.expected PRE-CREATION
autotests/data/codec_q/all-encoded-decode.q PRE-CREATION
autotests/data/codec_q/all-encoded-decode.q.expected PRE-CREATION
autotests/data/codec_q/basic-encode PRE-CREATION
autotests/data/codec_q/basic-encode.expected PRE-CREATION
autotests/data/codec_q/null-decode.q PRE-CREATION
autotests/data/codec_q/null-decode.q.expected PRE-CREATION
autotests/data/codec_q/null-encode PRE-CREATION
autotests/data/codec_q/null-encode.expected PRE-CREATION
autotests/data/codec_quoted-printable/basic-decode.quoted-printable PRE-CREATION
autotests/data/codec_quoted-printable/basic-decode.quoted-printable.expected PRE-CREATION
autotests/data/codec_quoted-printable/basic-encode PRE-CREATION
autotests/data/codec_quoted-printable/basic-encode.expected PRE-CREATION
autotests/data/codec_quoted-printable/corrupt.quoted-printable PRE-CREATION
autotests/data/codec_quoted-printable/corrupt.quoted-printable.expected PRE-CREATION
autotests/data/codec_quoted-printable/corrupt2.quoted-printable PRE-CREATION
autotests/data/codec_quoted-printable/corrupt2.quoted-printable.expected PRE-CREATION
autotests/data/codec_quoted-printable/corrupt3.quoted-printable PRE-CREATION
autotests/data/codec_quoted-printable/corrupt3.quoted-printable.expected PRE-CREATION
autotests/data/codec_quoted-printable/corrupt4.quoted-printable PRE-CREATION
autotests/data/codec_quoted-printable/corrupt4.quoted-printable.expected PRE-CREATION
autotests/data/codec_quoted-printable/wrap-encode PRE-CREATION
autotests/data/codec_quoted-printable/wrap-encode.expected PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode.expected PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/basic-encode PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION
autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/121103/diff/
Testing
-------
Test passes
Thanks,
Daniel Vrátil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141111/490fd278/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list