<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121103/">https://git.reviewboard.kde.org/r/121103/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated Nov. 11, 2014, 2:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcodecs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This class can be very useful to many applications that need to deal with email
address validation, and so it should not be hidden somewhere in PIM, but
should be available in some more visibile framework. Also I need to kill the
KPimUtils framework, and we don't really have any better-fitting framework
available at this moment :)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test passes</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcodecsbase64.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcodecsidentity.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcodecsidentity.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcodecsqp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcodecsqp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcodecsuuencode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcodecsuuencode.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kemailaddress.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kemailaddress.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(adc0f2ab8706cd120041df0ef97ca19cb3aa9315)</span></li>
<li>src/kcodecs.h <span style="color: grey">(48effbbe9cb26586c94c4d1492604345c0e1ca0b)</span></li>
<li>src/kcodecs.cpp <span style="color: grey">(4fd660d28b6db98bc63140ca6e9852947481c6f0)</span></li>
<li>src/kcodecsbase64.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/null-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/null-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-uuencode/basic-decode.x-uuencode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-uuencode/basic-decode.x-uuencode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcodecstest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcodecstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kemailaddresstest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kemailaddresstest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/rfc2047test.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/rfc2047test.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(4c41ba20809d063d6fe2a17833f87fd89df538e5)</span></li>
<li>autotests/base64benchmark.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/codectest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/codectest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/basic-decode.b <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/basic-decode.b.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/basic-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/basic-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/null-decode.b <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/null-decode.b.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/null-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/null-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/padding0-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/padding0-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/padding1-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/padding1-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/padding2-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_b/padding2-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/basic-decode.base64 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/basic-decode.base64.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/basic-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/basic-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/corrupt.base64 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/corrupt.base64.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/very_small-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_base64/very_small-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/all-encoded-decode.q <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/all-encoded-decode.q.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/basic-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/basic-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/null-decode.q <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/null-decode.q.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/null-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_q/null-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/basic-decode.quoted-printable <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/basic-decode.quoted-printable.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/basic-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/basic-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt.quoted-printable <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt.quoted-printable.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt2.quoted-printable <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt2.quoted-printable.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt3.quoted-printable <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt3.quoted-printable.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt4.quoted-printable <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/corrupt4.quoted-printable.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/wrap-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_quoted-printable/wrap-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/basic-encode <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/basic-encode.expected <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231.expected <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121103/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>