Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

[Michael Hansen]

Ping?

On Thu, Oct 23, 2014 at 10:09 AM, Michael Hansen <zrax0111 at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120760/
>   Review request for KDE Frameworks and Christoph Cullmann.
> By Michael Hansen.
>  *Repository: * ktexteditor
> Description
>
> Fix for incorrect soft-tabs alignment after beginning-of-line, by taking the current cursor position into account when expanding tabs to spaces.
>
> This also now uses the indentation width rather than the tab width, as I see "Tab Width" as being the actual width of the \t character, and "Indentation width" as being the next alignment position for virtual indentation.  This more closely matches other editors (e.g. vim) which have similar indentation control.
>
>   Testing
>
> Typed the testcase in bug 340212 with various indent/tab width settings.  Only Soft Tab mode is affected by this change.
>
> With Indent 4/Tab 4:
>     int     x;
>     string  y;
>     bool    z;
>
> With Indent 4/Tab 8:
>     int     x;
>     string  y;
>     bool    z;
>
> With Indent 8/Tab 8 (single [tab] on the first line):
>         int     x;
>         string  y;
>         bool    z;
>
>   Diffs
>
>    - src/document/katedocument.h
>    (cc43d6ab033c3d5bcf5b90a18ef9c2dc78b220cf)
>    - src/document/katedocument.cpp
>    (edcf7a430412d30ca2ed210465690bc8e2c42d5b)
>
> View Diff <https://git.reviewboard.kde.org/r/120760/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141112/9d9fd008/attachment.html>