Review Request 118253: Port KWindowSystem::raiseWindow and ::lowerWindow to XCB

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118253/#review58651
-----------------------------------------------------------

Ship it!


I am no expert on the topic, but since very few people except you are, I am going to give it a try. Based on reading xcb API doc and checking XCB defines are the same as the XLib defines they replace, and since it still builds, I am going to say "ship it".

- Aurélien Gâteau


On May 22, 2014, 8:56 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118253/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 8:56 a.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Port KWindowSystem::raiseWindow and ::lowerWindow to XCB
> 
> No unit test as that is extremely difficult to test as it depends
> on what the window manager running in the test environment supports.
> The code supports two variants for whether the WM supports the feature
> or not, thus the test would need to change the WM during execution and
> this would affect other running tests.
> 
> 
> Diffs
> -----
> 
>   src/kwindowsystem_x11.cpp 74370cb96229a3042fbfd061ae442b5cf2b403e9 
> 
> Diff: https://git.reviewboard.kde.org/r/118253/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140528/1afb2294/attachment.html>