<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118253/">https://git.reviewboard.kde.org/r/118253/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am no expert on the topic, but since very few people except you are, I am going to give it a try. Based on reading xcb API doc and checking XCB defines are the same as the XLib defines they replace, and since it still builds, I am going to say "ship it".</pre>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On May 22nd, 2014, 8:56 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 22, 2014, 8:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port KWindowSystem::raiseWindow and ::lowerWindow to XCB
No unit test as that is extremely difficult to test as it depends
on what the window manager running in the test environment supports.
The code supports two variants for whether the WM supports the feature
or not, thus the test would need to change the WM during execution and
this would affect other running tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(74370cb96229a3042fbfd061ae442b5cf2b403e9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118253/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>