Review Request 118289: Change titlewidget from bold to increased font size

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118289/
-----------------------------------------------------------

(Updated May 26, 2014, 11:57 p.m.)


Review request for KDE Frameworks, KDE Usability and Christoph Feck.


Changes
-------

* Updated font size to 1.4 times: Using 1.2, as suggested by Christoph doesn't provide enough visual weight. I'll add screenshots with 1.2 and 1.4, so others can compare it as well. My personal preference would be 1.4, as it makes the whole thing looks a bit more "ballsy", but I can understand if you'd prefer something more "toned down", as it also makes the widget increase a bit in height. 1.2 really doesn't provide much difference to me, though.

* In the eventFilter, also check for FontChange events to update the stylesheet.

* Added a note about the sizing in the APIDOCS

* APIDOCS were out of date in some places, fixed that as well

I have a local branch with separate patches, attached here is the complete diff of my branch.


Repository: kwidgetsaddons


Description
-------

Change titlewidget from bold to increased font size

This patch removes the bold weight from KTitleWidget and makes the text
a bit bigger, improving focus. This is more in line with common
expectations of a title, and it's more in line with Plasma 5's
typography.


Diffs (updated)
-----

  src/ktitlewidget.h a0c5641 
  src/ktitlewidget.cpp b1f3ca7 

Diff: https://git.reviewboard.kde.org/r/118289/diff/


Testing
-------


File Attachments
----------------

titlewidget in systemsettings (before)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png
titlewidget in systemsettings (after)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png
titlewidget in kate (before)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png
titlewidget in kate (after)
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140526/b5922948/attachment.html>