Review Request 118289: Change titlewidget from bold to increased font size

[Sebastian Kügler]

> On May 26, 2014, 10:18 a.m., Christoph Feck wrote:
> > The original screen shot looks bad, because the bold font looks smaller than the normal font. This might be because of wrong hinting settings, or because of a bad font design.
> > 
> > Regarding the scaling factor, CSS recommends 1.2 between sizes.
> > 
> > Could you also check, whether it reacts to font size changes?
> > 
> > Additionally, a programmer might be surprised, that the specified font size is not respected, so you either need to clarify in the API docs, or create a method "setFontSizeFactor()", which defaults to 1.2, but can be changed back to 1.0.
> 
> Christoph Feck wrote:
>     Let me add that titles have used bold face since centuries :)

Heh, yes. :)

We've also "for centuries" attempted to remove usage of Bold where not necessary semantically. ;)

In Plasma 5 context, we rely much more on font-sizing for these semantics, and are almost not using Bold at all. This makes systemsettings fit in much better, for example. Although this widget, in principle, has nothing to do with Plasma, it still gives it a bit more of a modern feeling.

I'll clarify the sizing in the API docs for now. It's a bit late in the cycle to introduce new API, which initially isn't even used.

Thanks for the review, new patch coming up...


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118289/#review58454
-----------------------------------------------------------


On May 26, 2014, 10 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118289/
> -----------------------------------------------------------
> 
> (Updated May 26, 2014, 10 a.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Change titlewidget from bold to increased font size
> 
> This patch removes the bold weight from KTitleWidget and makes the text
> a bit bigger, improving focus. This is more in line with common
> expectations of a title, and it's more in line with Plasma 5's
> typography.
> 
> 
> Diffs
> -----
> 
>   src/ktitlewidget.cpp b1f3ca714670a6eaa49048d67221d90d11480cec 
> 
> Diff: https://git.reviewboard.kde.org/r/118289/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> titlewidget in systemsettings (before)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png
> titlewidget in systemsettings (after)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png
> titlewidget in kate (before)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png
> titlewidget in kate (after)
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140526/2905ed33/attachment.html>