<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118289/">https://git.reviewboard.kde.org/r/118289/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, KDE Usability and Christoph Feck.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 26, 2014, 11:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Updated font size to 1.4 times: Using 1.2, as suggested by Christoph doesn't provide enough visual weight. I'll add screenshots with 1.2 and 1.4, so others can compare it as well. My personal preference would be 1.4, as it makes the whole thing looks a bit more "ballsy", but I can understand if you'd prefer something more "toned down", as it also makes the widget increase a bit in height. 1.2 really doesn't provide much difference to me, though.
* In the eventFilter, also check for FontChange events to update the stylesheet.
* Added a note about the sizing in the APIDOCS
* APIDOCS were out of date in some places, fixed that as well
I have a local branch with separate patches, attached here is the complete diff of my branch.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change titlewidget from bold to increased font size
This patch removes the bold weight from KTitleWidget and makes the text
a bit bigger, improving focus. This is more in line with common
expectations of a title, and it's more in line with Plasma 5's
typography.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ktitlewidget.h <span style="color: grey">(a0c5641)</span></li>
<li>src/ktitlewidget.cpp <span style="color: grey">(b1f3ca7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118289/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png">titlewidget in systemsettings (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png">titlewidget in systemsettings (after)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png">titlewidget in kate (before)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png">titlewidget in kate (after)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>