Review Request 117136: Expose KAssistantDialog buttons

Aleix Pol Gonzalez aleixpol at kde.org
Fri Mar 28 14:56:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117136/
-----------------------------------------------------------

(Updated March 28, 2014, 2:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Repository: kwidgetsaddons


Description
-------

Fix API regression in KAssistantDialog in KWidgetsAddons.

The previous, next and finish button used to be exposed through the KDialog::UserN buttons. This is not a KDialog anymore and QDialogButtonBox doesn't expose these.

This patch exposes the buttons in 3 different methods.


Diffs
-----

  src/kassistantdialog.cpp 00895f0 
  src/kassistantdialog.h e7ffaf5 

Diff: https://git.reviewboard.kde.org/r/117136/diff/


Testing
-------

Using it from the ongoing port of dr konqi.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/b7f3dbd6/attachment.html>


More information about the Kde-frameworks-devel mailing list