Review Request 117136: Expose KAssistantDialog buttons
Commit Hook
null at kde.org
Fri Mar 28 14:56:44 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117136/#review54448
-----------------------------------------------------------
This review has been submitted with commit 64fa4c2479d3fde650bd83977bdea4aad7edf795 by Aleix Pol to branch master.
- Commit Hook
On March 28, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117136/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:44 p.m.)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> Fix API regression in KAssistantDialog in KWidgetsAddons.
>
> The previous, next and finish button used to be exposed through the KDialog::UserN buttons. This is not a KDialog anymore and QDialogButtonBox doesn't expose these.
>
> This patch exposes the buttons in 3 different methods.
>
>
> Diffs
> -----
>
> src/kassistantdialog.cpp 00895f0
> src/kassistantdialog.h e7ffaf5
>
> Diff: https://git.reviewboard.kde.org/r/117136/diff/
>
>
> Testing
> -------
>
> Using it from the ongoing port of dr konqi.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/e16894f8/attachment.html>
More information about the Kde-frameworks-devel
mailing list