Review Request 117137: Remove use of KPluginFactory::componentName()
Alex Merry
alex.merry at kde.org
Fri Mar 28 14:49:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117137/
-----------------------------------------------------------
Review request for KDE Frameworks and David Faure.
Repository: kcmutils
Description
-------
Remove use of KPluginFactory::componentName()
This path would never have succeeded, as plugins do not have component
data compiled into them any more. Go straight to extracting the
information from the desktop file instead.
Diffs
-----
src/kpluginselector.cpp 34e4a83325e52babae4d28691abaf90f3576f379
Diff: https://git.reviewboard.kde.org/r/117137/diff/
Testing
-------
KCMUtils now builds with https://git.reviewboard.kde.org/r/117074/ applied to kservice. No unit tests :-(
Thanks,
Alex Merry
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/c1ef24ea/attachment.html>
More information about the Kde-frameworks-devel
mailing list