Review Request 117136: Expose KAssistantDialog buttons
David Edmundson
david at davidedmundson.co.uk
Fri Mar 28 14:53:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117136/#review54445
-----------------------------------------------------------
Ship it!
src/kassistantdialog.h
<https://git.reviewboard.kde.org/r/117136/#comment38095>
back.
- David Edmundson
On March 28, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117136/
> -----------------------------------------------------------
>
> (Updated March 28, 2014, 2:44 p.m.)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kwidgetsaddons
>
>
> Description
> -------
>
> Fix API regression in KAssistantDialog in KWidgetsAddons.
>
> The previous, next and finish button used to be exposed through the KDialog::UserN buttons. This is not a KDialog anymore and QDialogButtonBox doesn't expose these.
>
> This patch exposes the buttons in 3 different methods.
>
>
> Diffs
> -----
>
> src/kassistantdialog.cpp 00895f0
> src/kassistantdialog.h e7ffaf5
>
> Diff: https://git.reviewboard.kde.org/r/117136/diff/
>
>
> Testing
> -------
>
> Using it from the ongoing port of dr konqi.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140328/81d7e146/attachment.html>
More information about the Kde-frameworks-devel
mailing list