Review Request 116588: Improve the README

Alex Merry alex.merry at kde.org
Tue Mar 4 11:52:06 UTC 2014



> On March 4, 2014, 11:02 a.m., Alex Merry wrote:
> > README.md, line 9
> > <https://git.reviewboard.kde.org/r/116588/diff/1/?file=251921#file251921line9>
> >
> >     "allows to interact with" is bad grammar; "allows interaction with" would work, and "allows <foo> to interact with" would be better.  Maybe "clients" in place of <foo>?
> 
> Martin Gräßlin wrote:
>     what are "clients"? It's obvious if one knows what the framework does, but if you don't know a client could be anything.

Other options could be "applications" or "programs".  If you don't think any of them fit, and can't think of anything else, use the passive version ("allows interaction with").


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116588/#review51865
-----------------------------------------------------------


On March 4, 2014, 7:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116588/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 7:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> Improve the README
> 
> 
> Diffs
> -----
> 
>   README.md 2685b2e441ee2745c50712aac712be1081fec60d 
> 
> Diff: https://git.reviewboard.kde.org/r/116588/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140304/d4da4e15/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list