Review Request 119043: pollkit-qt-1 buildsystem adjustements

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/
-----------------------------------------------------------

(Updated June 30, 2014, 10:28 p.m.)


Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and Christophe Giboudeaux.


Changes
-------

adjusted pc files paths.
added ${GOBJECT_LIBRARIES} and ${GIO_LIBRARIES} to agent's link libraries: the build fails otherwise with -Wl, --no-undefined
requires would be great to fix, i agree, just need to think of the easiest way to cover both Qt4 and Qt5 cases. maybe separate pc files...


Repository: polkit-qt-1


Description
-------

added exported targets, simplify main CMakeLists...


Diffs (updated)
-----

  CMakeLists.txt 021bf88 
  PolkitQt-1Config.cmake.in 8b722a6 
  agent/CMakeLists.txt f1ba438 
  core/CMakeLists.txt e9b3ebb 
  gui/CMakeLists.txt 10b06ae 
  polkit-qt-1.pc.cmake 2f33204 
  polkit-qt-agent-1.pc.cmake 6ccc6dd 
  polkit-qt-core-1.pc.cmake a9e0750 
  polkit-qt-gui-1.pc.cmake 6b9c2cf 

Diff: https://git.reviewboard.kde.org/r/119043/diff/


Testing
-------

builds, cmake files visually inspected, seem fine


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140630/9d89017f/attachment.html>