Review Request 119043: pollkit-qt-1 buildsystem adjustements
Christophe Giboudeaux
cgiboudeaux at gmx.com
Mon Jun 30 19:33:30 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61318
-----------------------------------------------------------
The pkgconfig files need to be changed as well.
While changing the paths, fixing the 'Requires:' lines would be a good idea.
The rest looks correct.
- Christophe Giboudeaux
On June 30, 2014, 6:19 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119043/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 6:19 p.m.)
>
>
> Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and Christophe Giboudeaux.
>
>
> Repository: polkit-qt-1
>
>
> Description
> -------
>
> added exported targets, simplify main CMakeLists...
>
>
> Diffs
> -----
>
> CMakeLists.txt 021bf88
> PolkitQt-1Config.cmake.in 8b722a6
> agent/CMakeLists.txt f1ba438
> core/CMakeLists.txt e9b3ebb
> gui/CMakeLists.txt 10b06ae
>
> Diff: https://git.reviewboard.kde.org/r/119043/diff/
>
>
> Testing
> -------
>
> builds, cmake files visually inspected, seem fine
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140630/3dcb54da/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list