Review Request 119043: pollkit-qt-1 buildsystem adjustements

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119043/#review61326
-----------------------------------------------------------



agent/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42703>

    LINK_PUBLIC



agent/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42704>

    LINK_PRIVATE



core/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42699>

    PUBLIC was added in CMake 2.8.12, use LINK_PUBLIC



core/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42700>

    and LINK_PRIVATE



core/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42698>

    Not needed anymore



gui/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42701>

    LINK_PUBLIC



gui/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119043/#comment42702>

    LINK_PRIVATE


- Christophe Giboudeaux


On June 30, 2014, 8:28 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119043/
> -----------------------------------------------------------
> 
> (Updated June 30, 2014, 8:28 p.m.)
> 
> 
> Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and Christophe Giboudeaux.
> 
> 
> Repository: polkit-qt-1
> 
> 
> Description
> -------
> 
> added exported targets, simplify main CMakeLists...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 021bf88 
>   PolkitQt-1Config.cmake.in 8b722a6 
>   agent/CMakeLists.txt f1ba438 
>   core/CMakeLists.txt e9b3ebb 
>   gui/CMakeLists.txt 10b06ae 
>   polkit-qt-1.pc.cmake 2f33204 
>   polkit-qt-agent-1.pc.cmake 6ccc6dd 
>   polkit-qt-core-1.pc.cmake a9e0750 
>   polkit-qt-gui-1.pc.cmake 6b9c2cf 
> 
> Diff: https://git.reviewboard.kde.org/r/119043/diff/
> 
> 
> Testing
> -------
> 
> builds, cmake files visually inspected, seem fine
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140630/44f3b733/attachment.html>