git hooks for reviews mandatory?

[Albert Astals Cid]

El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure:
> On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin <notmart at gmail.com> wrote:
> > Hi all,
> > I was thinking, since the policy for committing in frameworks is to always
> > asking for a review, what about on repositories under frameworks/* adding
> > an
> > hook that accepts pushes only if the comment has a REVIEW: line?
> > 
> > I have been guilty too many times of not respecting that, mostly for not
> > thinking about it at all, maybe I'm not the only one, an artificial
> > enforce of
> > discipline like that *may* make sense.
> > 
> > opinions? would be useful, or mostly just an annoyance?
> 
> I've heard of many complaints about how noisy is kde-frameworks mailing
> list because of review requests. Also, I fear there's people not working at
> full speed in their respective projects because of review requests. Such
> change would scare me a bit, TBH.

+1 Sometimes you just know that a commit is right, making it slower because 
you need someone to review it is a no go for me (not that i'm doing much/any 
frameworks developement otoh).

Cheers,
  Albert

> 
> Aleix