git hooks for reviews mandatory?

Kevin Ottens ervin at kde.org
Sat Jun 21 08:33:51 UTC 2014


On Friday 20 June 2014 22:11:57 Albert Astals Cid wrote:
> El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure:
> > I've heard of many complaints about how noisy is kde-frameworks mailing
> > list because of review requests. Also, I fear there's people not working
> > at full speed in their respective projects because of review requests.
> > Such change would scare me a bit, TBH.
> 
> +1 Sometimes you just know that a commit is right, making it slower because
> you need someone to review it is a no go for me (not that i'm doing much/any
> frameworks developement otoh).

There's still the possibility to do like in Qt "Reviewed-By: Trust-me". The 
point of "forcing" reviews is to make sure people asks themselves the question 
in the first place.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140621/efda3a6f/attachment.sig>


More information about the Kde-frameworks-devel mailing list