Review Request 118514: Add KColumnResizer to KWidgetsAddons

[Christoph Feck]

> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote:
> > What about adding something like this to Qt ?
> 
> Christoph Feck wrote:
>     First, I was thinking the same. The efforts with KF5 work was to get as much features as possible into Qt, and only keep the stuff that isn't accepted in our libraries.
>     
>     But here, I am not really sure. Is the alignment requirement specific to KDE's guidelines?
> 
> Dominik Haumann wrote:
>     Reading the comments in http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ there seems to be quite a lot of interest in this, some also saying it should be in Qt.

Right. I will let Aurélien decide, if he wants to try getting it into Qt.

Otherwise, looks good so far. Lets wait a day for any other feedback.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59170
-----------------------------------------------------------


On June 5, 2014, 12:38 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118514/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper class I created long ago to help maintain uniform widths across layouts. You can learn more about it from the blog post I wrote back then: http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the API a bit, added some documentation, and here it is.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 854e916 
>   autotests/kcolumnresizertest-forms.ui PRE-CREATION 
>   autotests/kcolumnresizertest-grid-and-form.ui PRE-CREATION 
>   autotests/kcolumnresizertest-grids.ui PRE-CREATION 
>   autotests/kcolumnresizertest.h PRE-CREATION 
>   autotests/kcolumnresizertest.cpp PRE-CREATION 
>   docs/pics/kcolumnresizer.png PRE-CREATION 
>   src/CMakeLists.txt 27b9084 
>   src/kcolumnresizer.h PRE-CREATION 
>   src/kcolumnresizer.cpp PRE-CREATION 
>   tests/CMakeLists.txt eccf887 
>   tests/kcolumnresizertest.h PRE-CREATION 
>   tests/kcolumnresizertest.cpp PRE-CREATION 
>   tests/kcolumnresizertest.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118514/diff/
> 
> 
> Testing
> -------
> 
> Manual test program behaves as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140605/cfb5f297/attachment.html>