Review Request 118514: Add KColumnResizer to KWidgetsAddons

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118514/#review59163
-----------------------------------------------------------


Regarding "remove" type functions, I agree we need them.

Please also check if adding a widget multiple times does work.

There could also be an "addLayout()" (and removeLayout()) function, and on each "update", it would check which widgets are in there, and handle them.


src/kcolumnresizer.h
<https://git.reviewboard.kde.org/r/118514/#comment41186>

    Does it make sense to make "= 0" the default value for the column?



src/kcolumnresizer.cpp
<https://git.reviewboard.kde.org/r/118514/#comment41188>

    I think our style guide requires indenting the initializers.



src/kcolumnresizer.cpp
<https://git.reviewboard.kde.org/r/118514/#comment41189>

    indent



src/kcolumnresizer.cpp
<https://git.reviewboard.kde.org/r/118514/#comment41190>

    indent



src/kcolumnresizer.cpp
<https://git.reviewboard.kde.org/r/118514/#comment41196>

    What would be nice is if the widget you add is actually a GroupBox containing a supported layout, then it would internally call addWidgetsFromLayout().
    
    Remains the issue with layouts whose children could change...


- Christoph Feck


On June 4, 2014, 9:52 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118514/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 9:52 a.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> I have been asked to add ColumnResizer to KWidgetAddons. ColumnResizer is a helper class I created long ago to help maintain uniform widths across layouts. You can learn more about it from the blog post I wrote back then: http://agateau.com/2011/clean-up-your-layouts-with-columnresizer/ . I simplified the API a bit, added some documentation, and here it is.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 27b9084 
>   src/kcolumnresizer.h PRE-CREATION 
>   src/kcolumnresizer.cpp PRE-CREATION 
>   tests/CMakeLists.txt eccf887 
>   tests/kcolumnresizertest.h PRE-CREATION 
>   tests/kcolumnresizertest.cpp PRE-CREATION 
>   tests/kcolumnresizertest.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118514/diff/
> 
> 
> Testing
> -------
> 
> Manual test program behaves as expected.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140604/d6bb7d57/attachment.html>