Review Request 115345: Fix kimageformats build with MSVC

[Alexander Richardson]

> On Jan. 27, 2014, 11:36 p.m., Alex Merry wrote:
> > Just ran a quick test, using the imageconverter tool in the tests/ directory.  I created orig.pcx and orig.pic before applying the patch, with
> > ./imageconverter /some/image.bmp orig.pcx
> > ./imageconverter /some/image.bmp orig.pic
> > and then did the same after patching with patched.pcx and patched.pic.  Then
> > cmp orig.pcx patched.pcx
> > is fine, but
> > cmp orig.pic patched.pic
> > orig.pic patched.pic differ: byte 93, line 1
> > 
> > So something has gone wrong :-)
> 
> Alex Merry wrote:
>     Incidentally, somewhere down my TODO list is autotests for kimageformats.  I was thinking lossy formats would be an issue, but this sort of test should work fine (I don't think any image formats actually introduce randomness).

Issue should be fixed now. Can't test whether it works because currently I only have access to my Windows machine and it won't build before this patch.
I will check whether it works tomorrow evening


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/#review48422
-----------------------------------------------------------


On Jan. 28, 2014, 12:40 a.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115345/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 12:40 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> 1) Use #pragma pack instead of __attribute__((packed))
> 
> This is available on all supported compilers, the attribute does not exist
> for MSVC
> --------------------------------------------------
> 2) Use q{To,From}BigEndian instead of hton* and ntoh*
> 
> These functions don't seem to be available as inline functions on win32
> 
> 
> Diffs
> -----
> 
>   src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388 
>   src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294 
>   src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71 
> 
> Diff: https://git.reviewboard.kde.org/r/115345/diff/
> 
> 
> Testing
> -------
> 
> didn't compile before, does now
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/090d7311/attachment.html>