Review Request 115345: Fix kimageformats build with MSVC

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115345/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 12:40 a.m.)


Review request for KDE Frameworks and Alex Merry.


Changes
-------

fix qint32 -> qint16 issue


Repository: kimageformats


Description
-------

1) Use #pragma pack instead of __attribute__((packed))

This is available on all supported compilers, the attribute does not exist
for MSVC
--------------------------------------------------
2) Use q{To,From}BigEndian instead of hton* and ntoh*

These functions don't seem to be available as inline functions on win32


Diffs (updated)
-----

  src/imageformats/pcx.cpp e0af73b4cac30afcc158e094cd6554a6e4b59388 
  src/imageformats/pic_read.cpp 42432185c362497efd596a8ce4f1cdae283ed294 
  src/imageformats/pic_write.cpp 99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71 

Diff: https://git.reviewboard.kde.org/r/115345/diff/


Testing
-------

didn't compile before, does now


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140127/892863b2/attachment.html>