<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115345/">https://git.reviewboard.kde.org/r/115345/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2014, 11:36 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just ran a quick test, using the imageconverter tool in the tests/ directory. I created orig.pcx and orig.pic before applying the patch, with
./imageconverter /some/image.bmp orig.pcx
./imageconverter /some/image.bmp orig.pic
and then did the same after patching with patched.pcx and patched.pic. Then
cmp orig.pcx patched.pcx
is fine, but
cmp orig.pic patched.pic
orig.pic patched.pic differ: byte 93, line 1
So something has gone wrong :-)</pre>
</blockquote>
<p>On January 27th, 2014, 11:37 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Incidentally, somewhere down my TODO list is autotests for kimageformats. I was thinking lossy formats would be an issue, but this sort of test should work fine (I don't think any image formats actually introduce randomness).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Issue should be fixed now. Can't test whether it works because currently I only have access to my Windows machine and it won't build before this patch.
I will check whether it works tomorrow evening</pre>
<br />
<p>- Alexander</p>
<br />
<p>On January 28th, 2014, 12:40 a.m. CET, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2014, 12:40 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Use #pragma pack instead of __attribute__((packed))
This is available on all supported compilers, the attribute does not exist
for MSVC
--------------------------------------------------
2) Use q{To,From}BigEndian instead of hton* and ntoh*
These functions don't seem to be available as inline functions on win32</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">didn't compile before, does now</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/imageformats/pcx.cpp <span style="color: grey">(e0af73b4cac30afcc158e094cd6554a6e4b59388)</span></li>
<li>src/imageformats/pic_read.cpp <span style="color: grey">(42432185c362497efd596a8ce4f1cdae283ed294)</span></li>
<li>src/imageformats/pic_write.cpp <span style="color: grey">(99cd6a1ccff04fdeee4a3b5c2b3d76d9fd89ca71)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115345/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>