Review Request 115292: Do Configure Checks in the Correct Language
Christoph Cullmann
cullmann at kde.org
Fri Jan 24 14:12:04 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115292/#review48216
-----------------------------------------------------------
Patch fixes the issue for me here, think perhaps the same is needed for kjs.
- Christoph Cullmann
On Jan. 24, 2014, 1:55 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115292/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 1:55 p.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Repository: kde4support
>
>
> Description
> -------
>
> A recent change in ECM revealed an issue with ConfigureChecks.cmake, where the check_symbol_exist calls would use the C compiler (with CFLAGS) and the compilation would happen in C++ (with CXXFLAGS). This change ports all checks to CXX where possible.
>
>
> Diffs
> -----
>
> src/ConfigureChecks.cmake 7c8951f
>
> Diff: https://git.reviewboard.kde.org/r/115292/diff/
>
>
> Testing
> -------
>
> 1. Refreshed builds for ECM and KDE4Support, both building OK
> 2. $ grep HAVE_GETADDRINFO src/config-network.h
> #define HAVE_GETADDRINFO 1
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140124/c6b9c3a7/attachment.html>
More information about the Kde-frameworks-devel
mailing list