Review Request 115292: Do Configure Checks in the Correct Language

David Narváez david.narvaez at computer.org
Fri Jan 24 13:55:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115292/
-----------------------------------------------------------

Review request for KDE Frameworks and Alex Merry.


Repository: kde4support


Description
-------

A recent change in ECM revealed an issue with ConfigureChecks.cmake, where the check_symbol_exist calls would use the C compiler (with CFLAGS) and the compilation would happen in C++ (with CXXFLAGS). This change ports all checks to CXX where possible.


Diffs
-----

  src/ConfigureChecks.cmake 7c8951f 

Diff: https://git.reviewboard.kde.org/r/115292/diff/


Testing
-------

1. Refreshed builds for ECM and KDE4Support, both building OK
2.  $ grep HAVE_GETADDRINFO src/config-network.h 
#define HAVE_GETADDRINFO 1


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140124/7d1119a6/attachment.html>


More information about the Kde-frameworks-devel mailing list