Review Request 115504: Only perform tests for plugins that are built

Alex Merry kde at randomguy3.me.uk
Thu Feb 20 13:04:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115504/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 1:04 p.m.)


Review request for KDE Frameworks and Alex Merry.


Changes
-------

Make WebP tests conditional, and fix conditional for JP2 tests, so that they actually run.


Repository: kimageformats


Description
-------

Only perform tests for plugins that are built

This both excludes the autotests and tests subdirs if the user sets
BUILD_TESTING off, and makes sure we do not run tests for formats that
were not built due to dependencies not being found.


Diffs (updated)
-----

  CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc 
  autotests/CMakeLists.txt 14db235bcea9bb6882539803e715a6e051ea6c18 
  src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6 

Diff: https://git.reviewboard.kde.org/r/115504/diff/


Testing
-------

Builds and tests pass.  Builds with BUILD_TESTING off (and tests are not build, and make test does nothing).  Commented out the optional find_package calls; still built and tests still passed.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/5d08bf28/attachment.html>


More information about the Kde-frameworks-devel mailing list