Review Request 115504: Only perform tests for plugins that are built

David Faure faure at kde.org
Sun Feb 23 08:35:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115504/#review50563
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Feb. 20, 2014, 1:04 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115504/
> -----------------------------------------------------------
> 
> (Updated Feb. 20, 2014, 1:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Only perform tests for plugins that are built
> 
> This both excludes the autotests and tests subdirs if the user sets
> BUILD_TESTING off, and makes sure we do not run tests for formats that
> were not built due to dependencies not being found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc 
>   autotests/CMakeLists.txt 14db235bcea9bb6882539803e715a6e051ea6c18 
>   src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6 
> 
> Diff: https://git.reviewboard.kde.org/r/115504/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass.  Builds with BUILD_TESTING off (and tests are not build, and make test does nothing).  Commented out the optional find_package calls; still built and tests still passed.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140223/ba89b87f/attachment.html>


More information about the Kde-frameworks-devel mailing list