Review Request 115504: Only perform tests for plugins that are built

Alex Merry kde at randomguy3.me.uk
Thu Feb 20 12:38:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115504/
-----------------------------------------------------------

(Updated Feb. 20, 2014, 12:38 p.m.)


Review request for KDE Frameworks.


Changes
-------

Comment out broken tests, instead of using if(FALSE)


Repository: kimageformats


Description
-------

Only perform tests for plugins that are built

This both excludes the autotests and tests subdirs if the user sets
BUILD_TESTING off, and makes sure we do not run tests for formats that
were not built due to dependencies not being found.


Diffs (updated)
-----

  CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc 
  autotests/CMakeLists.txt bedc3ad451128365699ec8f1392c68993934453b 
  src/imageformats/CMakeLists.txt 7cafd18105a7219a9c761193012f87625f74d995 

Diff: https://git.reviewboard.kde.org/r/115504/diff/


Testing
-------

Builds and tests pass.  Builds with BUILD_TESTING off (and tests are not build, and make test does nothing).  Commented out the optional find_package calls; still built and tests still passed.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/7c4af9c1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list