Review Request 115504: Only perform tests for plugins that are built

[Alex Merry]

> On Feb. 20, 2014, 12:14 p.m., Kevin Ottens wrote:
> > autotests/CMakeLists.txt, line 82
> > <https://git.reviewboard.kde.org/r/115504/diff/1/?file=242132#file242132line82>
> >
> >     Didn't you mean if (BUILD_EPS_PLUGIN) ? This line confuses me. :-)

Hmm... it is a little non-obvious, now you mention it.  It is disabled for the reason mentioned in the comment above it; perhaps it would be clearer if I just commented out those lines.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115504/#review50341
-----------------------------------------------------------


On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115504/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 5:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> -------
> 
> Only perform tests for plugins that are built
> 
> This both excludes the autotests and tests subdirs if the user sets
> BUILD_TESTING off, and makes sure we do not run tests for formats that
> were not built due to dependencies not being found.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 
>   autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a 
>   src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 
> 
> Diff: https://git.reviewboard.kde.org/r/115504/diff/
> 
> 
> Testing
> -------
> 
> Builds and tests pass.  Builds with BUILD_TESTING off (and tests are not build, and make test does nothing).  Commented out the optional find_package calls; still built and tests still passed.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140220/1e440c8a/attachment.html>