Review Request 115421: Clean up the CMakeLists.txt files

Kevin Ottens ervin at kde.org
Sun Feb 16 10:20:30 UTC 2014


Hello,

On Saturday 15 February 2014 23:27:40 David Faure wrote:
> Looks like a historical thing to me, from before kstyle got integrated into
> frameworkintegration.
> 
> If I read git log correctly, this src/kstyle/CMakeLists.txt file comes from
> Kévin's commit 3864cfe2347af01b.
> 
> Kévin, any reason to make it possible to build kstyle separately, within
> frameworkintegration?

No reason whatsoever. Definitely historical, not needed anymore IMO.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140216/1b610f5c/attachment.sig>


More information about the Kde-frameworks-devel mailing list