Review Request 115421: Clean up the CMakeLists.txt files

[David Faure]

On Friday 07 February 2014 13:59:06 Alex Merry wrote:
> On 07/02/14 08:58, David Faure wrote:
> > On Saturday 01 February 2014 13:27:49 Alex Merry wrote:
> >> - KStyle can once again be built standalone
> > 
> > Is there any reason for this?
> > 
> > I ask because I noticed that this was another place where the KF5 version
> > had to be updated at release time, the only one that is not in
> > frameworks/*/CMakeLists.txt.
> > If it's needed that's fine, I adapted my scripts, but I'm just surprised.
> 
> None that I know of; it was clearly intended in the original CMake
> scripts, so I just repaired it.  The only use for it that I see is that
> you might want to build the KStyle library as a dependency of something
> else without bothering about the platform plugins.

Looks like a historical thing to me, from before kstyle got integrated into 
frameworkintegration.

If I read git log correctly, this src/kstyle/CMakeLists.txt file comes from 
Kévin's commit 3864cfe2347af01b.

Kévin, any reason to make it possible to build kstyle separately, within 
frameworkintegration?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5