Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115629/#review49608
-----------------------------------------------------------


Well, clearly the use of a pointer was because of the "either a QApp or a KApp" logic.
Since it's always a QApp now, indeed it should be changed to be on the stack.

Other than that, +1.

- David Faure


On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115629/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Jekyll Wu.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> The parsed command line values are kept in the DrKonqi singleton which
> replaces the static access to the KCmdLineArgs.
> 
> 
> Diffs
> -----
> 
>   drkonqi/drkonqi.h 95e64dc 
>   drkonqi/drkonqi.cpp ccb1c42 
>   drkonqi/drkonqibackends.cpp 064d07d 
>   drkonqi/drkonqidialog.cpp 3fc1549 
>   drkonqi/main.cpp 1337dbe 
> 
> Diff: https://git.reviewboard.kde.org/r/115629/diff/
> 
> 
> Testing
> -------
> 
> crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140211/9f5a1a39/attachment.html>