Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption
Martin Gräßlin
mgraesslin at kde.org
Wed Feb 12 07:24:31 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115629/
-----------------------------------------------------------
(Updated Feb. 12, 2014, 8:24 a.m.)
Review request for KDE Frameworks and Jekyll Wu.
Changes
-------
create QApplication on stack
Repository: kde-runtime
Description
-------
The parsed command line values are kept in the DrKonqi singleton which
replaces the static access to the KCmdLineArgs.
Diffs (updated)
-----
drkonqi/drkonqi.h 95e64dc
drkonqi/drkonqi.cpp ccb1c42
drkonqi/drkonqibackends.cpp 064d07d
drkonqi/drkonqidialog.cpp 3fc1549
drkonqi/main.cpp 1337dbe
Diff: https://git.reviewboard.kde.org/r/115629/diff/
Testing
-------
crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning.
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140212/ffca6e89/attachment.html>
More information about the Kde-frameworks-devel
mailing list