Review Request 115629: Port DrKonqi to QCommandLineParser and QCommandLineOption

[Aleix Pol Gonzalez]

> On Feb. 10, 2014, 4:14 p.m., Aleix Pol Gonzalez wrote:
> > drkonqi/main.cpp, line 74
> > <https://git.reviewboard.kde.org/r/115629/diff/1/?file=243089#file243089line74>
> >
> >     You can instantiate QApplication in the stack, instead of calling new+delete.
> >     
> >     Also you probably want to create it in the beginning of the main function body.
> 
> Martin Gräßlin wrote:
>     I'm fine with changing it, but I'd like the opinion of one of the people who are more familiar with the code base. It used to have the QApplication pointer and I don't know why. I assume it's because it used to either create a QApplication or a KApplication. If that's the only reason I'm happy to change the code, otherwise I would keep it with the pointer variant.

Fair enough, other than that +1.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115629/#review49455
-----------------------------------------------------------


On Feb. 10, 2014, 4:06 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115629/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 4:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Jekyll Wu.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> The parsed command line values are kept in the DrKonqi singleton which
> replaces the static access to the KCmdLineArgs.
> 
> 
> Diffs
> -----
> 
>   drkonqi/drkonqi.h 95e64dc 
>   drkonqi/drkonqi.cpp ccb1c42 
>   drkonqi/drkonqibackends.cpp 064d07d 
>   drkonqi/drkonqidialog.cpp 3fc1549 
>   drkonqi/main.cpp 1337dbe 
> 
> Diff: https://git.reviewboard.kde.org/r/115629/diff/
> 
> 
> Testing
> -------
> 
> crashed one app, DrKonqi opened and all information seemed reasonable. Though I haven't tested all options as I also don't know all of their meaning.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140210/cbcd9e6a/attachment.html>