Review Request 115494: Build on Mac OS X

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/#review49027
-----------------------------------------------------------



src/kjs/ConfigureChecks.cmake
<https://git.reviewboard.kde.org/r/115494/#comment34632>

    Interestingly, this test fails on glibc; gcc suggests using std::signbit instead (which is exactly what it is looking for, but you can't use :: in symbols passed to check_cxx_symbol_exists due to the macro check).
    
    What is puzzling is that the same tests for isinf and isnan pass...
    
    Anyway, this is not massively relevant to your RR.



src/kjs/operations.h
<https://git.reviewboard.kde.org/r/115494/#comment34630>

    The configure check finds the *macro* signbit() in glibc, but ::signbit(d) requires it to be a function, which causes the build to fail.


- Alex Merry


On Feb. 5, 2014, 1:42 p.m., Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115494/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 1:42 p.m.)
> 
> 
> Review request for KDE Frameworks and Bernd Buschinski.
> 
> 
> Repository: kjs
> 
> 
> Description
> -------
> 
> Build on Mac OS X
> 
> Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so manually cast to the required type.
> 
> Also, there seems to be some magic with __signbit, it seems to be detected but then compilation fails. Prefer the suggested ::signbit() instead if available.
> 
> 
> Diffs
> -----
> 
>   src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f 
>   src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9 
>   src/kjs/interpreter.cpp e6996512fdeaf3b6973261ceb9a21e343d95e4c0 
>   src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 
> 
> Diff: https://git.reviewboard.kde.org/r/115494/diff/
> 
> 
> Testing
> -------
> 
> It compiles again on Mac OS X :)
> 
> 
> Thanks,
> 
> Harald Fernengel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/9aaa75eb/attachment-0001.html>