Review Request 115494: Build on Mac OS X

Harald Fernengel harry at kdevelop.org
Wed Feb 5 16:06:44 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/
-----------------------------------------------------------

(Updated Feb. 5, 2014, 4:06 p.m.)


Review request for KDE Frameworks and Bernd Buschinski.


Changes
-------

updated the signbit call to not use ::signbit as it seems to be a macro on some systems


Repository: kjs


Description
-------

Build on Mac OS X

Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so manually cast to the required type.

Also, there seems to be some magic with __signbit, it seems to be detected but then compilation fails. Prefer the suggested ::signbit() instead if available.


Diffs (updated)
-----

  src/kjs/ConfigureChecks.cmake 473da1c 
  src/kjs/global.h.cmake d821a72 
  src/kjs/interpreter.cpp e699651 
  src/kjs/operations.h a54f366 

Diff: https://git.reviewboard.kde.org/r/115494/diff/


Testing
-------

It compiles again on Mac OS X :)


Thanks,

Harald Fernengel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140205/beb63635/attachment.html>


More information about the Kde-frameworks-devel mailing list