<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115494/">https://git.reviewboard.kde.org/r/115494/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115494/diff/1/?file=241991#file241991line38" style="color: black; font-weight: bold; text-decoration: underline;">src/kjs/ConfigureChecks.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_cxx_symbol_exists</span><span class="p">(</span><span class="s">signbit</span> <span class="s2">"cmath"</span> <span class="s">HAVE_FUNC_STD_SIGNBIT</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_cxx_symbol_exists</span><span class="p">(</span><span class="s">signbit</span> <span class="s2">"cmath"</span> <span class="s">HAVE_FUNC_STD_SIGNBIT</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Interestingly, this test fails on glibc; gcc suggests using std::signbit instead (which is exactly what it is looking for, but you can't use :: in symbols passed to check_cxx_symbol_exists due to the macro check).
What is puzzling is that the same tests for isinf and isnan pass...
Anyway, this is not massively relevant to your RR.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115494/diff/1/?file=241994#file241994line139" style="color: black; font-weight: bold; text-decoration: underline;">src/kjs/operations.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">inline bool isInf(double d)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">139</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="o">::</span><span class="n">signbit</span><span class="p">(</span><span class="n">d</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The configure check finds the *macro* signbit() in glibc, but ::signbit(d) requires it to be a function, which causes the build to fail.</pre>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On February 5th, 2014, 1:42 p.m. UTC, Harald Fernengel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Bernd Buschinski.</div>
<div>By Harald Fernengel.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 1:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build on Mac OS X
Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so manually cast to the required type.
Also, there seems to be some magic with __signbit, it seems to be detected but then compilation fails. Prefer the suggested ::signbit() instead if available.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles again on Mac OS X :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kjs/ConfigureChecks.cmake <span style="color: grey">(473da1c19c9e8788e3ac407d382f8bcf4882a10f)</span></li>
<li>src/kjs/global.h.cmake <span style="color: grey">(d821a7264f0e2b46b422a8d68d397799a288bde9)</span></li>
<li>src/kjs/interpreter.cpp <span style="color: grey">(e6996512fdeaf3b6973261ceb9a21e343d95e4c0)</span></li>
<li>src/kjs/operations.h <span style="color: grey">(a54f366330b937a027d478cbe018a7c1c21c1625)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115494/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>