Review Request 121401: Add Windows VERSIONINFO to KF5CoreAddons.dll

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121401/#review71633
-----------------------------------------------------------


This probably shouldn't go in until ecm has a release with that other change in it, right ? Otherwise anyone building on windows will need ecm from git (do they already?)

- Jeremy Whiting


On Dec. 8, 2014, 10:01 p.m., Nicolás Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121401/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:01 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Add a Windows VERSIONINFO resource to KF5CoreAddons.dll, using the new macro in ECM (see /r/121400).
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt b2b46b1 
> 
> Diff: https://git.reviewboard.kde.org/r/121401/diff/
> 
> 
> Testing
> -------
> 
> Tested with CMake 3.0.2, MSVC2013, Windows 7. Explorer tooltip shows description and version. File properties shows all the new information.
> 
> 
> Thanks,
> 
> Nicolás Alvarez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141209/3ffebc5f/attachment.html>