Change in kio[master]: Work around non-determinism in tests

Jan Kundrát (Code Review) noreply at kde.org
Tue Dec 9 14:09:15 UTC 2014


Jan Kundrát has uploaded a new change for review.

  https://gerrit.vesnicky.cesnet.cz/r/208

Change subject: Work around non-determinism in tests
......................................................................

Work around non-determinism in tests

Apparently the order in which these events are emitted is
system-dependant (or maybe FS-dependant) -- either way, there was quite
a substantial amount of test failures on a RHEL7 VM with XFS.

Change-Id: I978d441278d271163da9b1eed086f0e405f132b3
---
M autotests/kdirlistertest.cpp
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.vesnicky.cesnet.cz:29418/kio refs/changes/08/208/1

diff --git a/autotests/kdirlistertest.cpp b/autotests/kdirlistertest.cpp
index 0ceee4e..ed31a15 100644
--- a/autotests/kdirlistertest.cpp
+++ b/autotests/kdirlistertest.cpp
@@ -433,8 +433,6 @@
     org::kde::KDirNotify::emitFilesAdded(QUrl::fromLocalFile(path));
     QTest::qWait(200);
     org::kde::KDirNotify::emitFilesChanged(QList<QUrl>() << QUrl::fromLocalFile(directoryFile));
-    QCOMPARE(m_refreshedItems.count(), 0);
-
     org::kde::KDirNotify::emitFilesChanged(QList<QUrl>() << QUrl::fromLocalFile(path));
     QVERIFY(waitForRefreshedItems());
     QCOMPARE(m_refreshedItems.count(), 1);

-- 
To view, visit https://gerrit.vesnicky.cesnet.cz/r/208
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I978d441278d271163da9b1eed086f0e405f132b3
Gerrit-PatchSet: 1
Gerrit-Project: kio
Gerrit-Branch: master
Gerrit-Owner: Jan Kundrát <jkt at kde.org>
Gerrit-Reviewer: Sysadmin Testing Account <null at kde.org>


More information about the Kde-frameworks-devel mailing list