Review Request 121401: Add Windows VERSIONINFO to KF5CoreAddons.dll

Nicolás Alvarez nicolas.alvarez at gmail.com
Tue Dec 9 05:01:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121401/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kcoreaddons


Description
-------

Add a Windows VERSIONINFO resource to KF5CoreAddons.dll, using the new macro in ECM (see /r/121400).


Diffs
-----

  src/lib/CMakeLists.txt b2b46b1 

Diff: https://git.reviewboard.kde.org/r/121401/diff/


Testing
-------

Tested with CMake 3.0.2, MSVC2013, Windows 7. Explorer tooltip shows description and version. File properties shows all the new information.


Thanks,

Nicolás Alvarez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141209/6ba96932/attachment.html>


More information about the Kde-frameworks-devel mailing list