Review Request 112699: Reorganize KDocTools cmake code

[Aleix Pol Gonzalez]

> On Sept. 12, 2013, 7:57 p.m., Stephen Kelly wrote:
> > > Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt.
> > > This should make it possible to move kdoctools to its own tier.
> > 
> > Why is this necessary to move it to its own tier? That wouldn't be an existing tier?
> > 
> > > Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake.
> > > Wouldn't it make sense to rename it to FindKDocTools.cmake?
> > 
> > I don't think it would. Is your 'At the moment' referring to 'pre repo-split' times while we're still building everything monolithically?
> > 
> > Thanks,
> >

I don't think it has much to do with it being in a pre-repo-split stage. I think that we have to think about how we want applications to use KDocTools eventually, as we do with our C++ code.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/#review39917
-----------------------------------------------------------


On Sept. 12, 2013, 5:22 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112699/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 5:22 p.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Description
> -------
> 
> Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt.
> This should make it possible to move kdoctools to its own tier.
> 
> Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake.
> Wouldn't it make sense to rename it to FindKDocTools.cmake?
> 
> 
> Diffs
> -----
> 
>   staging/kdoctools/CMakeLists.txt 7687f97 
>   staging/kdoctools/src/CMakeLists.txt 6910ef7 
> 
> Diff: http://git.reviewboard.kde.org/r/112699/diff/
> 
> 
> Testing
> -------
> 
> Builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/aa0d46ce/attachment.html>