<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112699/">http://git.reviewboard.kde.org/r/112699/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 12th, 2013, 7:57 p.m. UTC, <b>Stephen Kelly</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt.
> This should make it possible to move kdoctools to its own tier.
Why is this necessary to move it to its own tier? That wouldn't be an existing tier?
> Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake.
> Wouldn't it make sense to rename it to FindKDocTools.cmake?
I don't think it would. Is your 'At the moment' referring to 'pre repo-split' times while we're still building everything monolithically?
Thanks,
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think it has much to do with it being in a pre-repo-split stage. I think that we have to think about how we want applications to use KDocTools eventually, as we do with our C++ code.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On September 12th, 2013, 5:22 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Stephen Kelly.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Sept. 12, 2013, 5:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt.
This should make it possible to move kdoctools to its own tier.
Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake.
Wouldn't it make sense to rename it to FindKDocTools.cmake?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>staging/kdoctools/CMakeLists.txt <span style="color: grey">(7687f97)</span></li>
<li>staging/kdoctools/src/CMakeLists.txt <span style="color: grey">(6910ef7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112699/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>