Review Request 112699: Reorganize KDocTools cmake code

Aleix Pol Gonzalez aleixpol at kde.org
Fri Sep 13 11:15:58 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112699/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 11:15 a.m.)


Review request for KDE Frameworks and Stephen Kelly.


Changes
-------

Adds the log listing the features, in case it's built separately.


Description
-------

Move the finders from kdoctools/CMakeLists.txt to kdoctools/src/CMakeLists.txt.
This should make it possible to move kdoctools to its own tier.

Question: At the moment, to use kdoctools from an application, we'll have to include KDocToolsMacros.cmake.
Wouldn't it make sense to rename it to FindKDocTools.cmake?


Diffs (updated)
-----

  staging/kdoctools/CMakeLists.txt 7687f97 
  staging/kdoctools/src/CMakeLists.txt 6910ef7 

Diff: http://git.reviewboard.kde.org/r/112699/diff/


Testing
-------

Builds


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130913/4b15ae93/attachment.html>


More information about the Kde-frameworks-devel mailing list