Review Request 113388: Port knewstuff from KImageIO to QImageReader

[Jeremy Whiting]

> On Oct. 22, 2013, 10:46 a.m., Alex Merry wrote:
> > knewstuff/src/uploaddialog.cpp, lines 823-833
> > <http://git.reviewboard.kde.org/r/113388/diff/1/?file=204524#file204524line823>
> >
> >     Does this actually produce a list of the right form?  It looks like it will generate something like "png;;jpg;;jpeg;;gif;;[etc]", while the QFileDialog docs (http://doc-snapshot.qt-project.org/qt5-stable/qfiledialog.html#getOpenFileName) suggest you want something like "PNG image (*.png);;JPG image (*.jpg);;[etc]".
> >     
> >     The KImageIO code, incidentally, produced a different format again.  It also added an "All images" thing to the start.

Actually it probably doesn't generate the right string, and also after discussing with david on irc it's a better idea to use supportedMimeTypes() and give that to the QFileDialog instead, so I'll redo this patch that way.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113388/#review42163
-----------------------------------------------------------


On Oct. 22, 2013, 10:06 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113388/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 10:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Ported knewstuff from KImageIO to QImageReader to get the qimage supported file formats to put in a filter for QFileDialog.
> 
> 
> Diffs
> -----
> 
>   knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a 
>   knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b 
>   knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 
> 
> Diff: http://git.reviewboard.kde.org/r/113388/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131022/67a175ab/attachment.html>