Review Request 113388: Port knewstuff from KImageIO to QImageReader
Alex Merry
kde at randomguy3.me.uk
Tue Oct 22 16:46:33 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113388/#review42163
-----------------------------------------------------------
knewstuff/src/uploaddialog.cpp
<http://git.reviewboard.kde.org/r/113388/#comment30717>
Does this actually produce a list of the right form? It looks like it will generate something like "png;;jpg;;jpeg;;gif;;[etc]", while the QFileDialog docs (http://doc-snapshot.qt-project.org/qt5-stable/qfiledialog.html#getOpenFileName) suggest you want something like "PNG image (*.png);;JPG image (*.jpg);;[etc]".
The KImageIO code, incidentally, produced a different format again. It also added an "All images" thing to the start.
- Alex Merry
On Oct. 22, 2013, 4:06 p.m., Jeremy Whiting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113388/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 4:06 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Ported knewstuff from KImageIO to QImageReader to get the qimage supported file formats to put in a filter for QFileDialog.
>
>
> Diffs
> -----
>
> knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a
> knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b
> knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1
>
> Diff: http://git.reviewboard.kde.org/r/113388/diff/
>
>
> Testing
> -------
>
> Builds.
>
>
> Thanks,
>
> Jeremy Whiting
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131022/40d199b7/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list