Review Request 113388: Port knewstuff from KImageIO to QImageReader

Jeremy Whiting jpwhiting at kde.org
Wed Oct 23 21:45:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113388/
-----------------------------------------------------------

(Updated Oct. 23, 2013, 3:45 p.m.)


Review request for KDE Frameworks.


Changes
-------

Updated patch to use mime types rather than filter string. Though it still required another method in UploadDialog::Private to convert the QList<QByteArray> to QStringList.  Too bad we didn't catch that discrepancy when adding supportedMimeTypes() to QImageReader itself.


Repository: kdelibs


Description
-------

Ported knewstuff from KImageIO to QImageReader to get the qimage supported file formats to put in a filter for QFileDialog.


Diffs (updated)
-----

  knewstuff/src/CMakeLists.txt a42d35443c0d3596d8ef18e46a1ec905fd14a33a 
  knewstuff/src/uploaddialog.cpp 6e4630caf93fe7b589e3365c2459e3ae103f3b1b 
  knewstuff/src/uploaddialog_p.h dca105910890c618e16724fc1944afda508842c1 

Diff: http://git.reviewboard.kde.org/r/113388/diff/


Testing
-------

Builds.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20131023/d514bf7e/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list