Review Request 114076: Set KDE4_INCLUDES in KDE4SupportConfig

[David Faure]

On Sunday 24 November 2013 23:11:25 Stephen Kelly wrote:
> David Faure wrote:
> > It doesn't link to kde4support, and KConfigCore doesn't install forwarding
> > headers yet. So this is a temporary measure, the real fix being to
> > generate and install forwarding headers; but this fix allows to move the
> > two things forward independently.
> 
> Given the issues that I pointed out in the patch, a better solution might be
> this:
> 
> diff --git a/ktimezoned/CMakeLists.txt b/ktimezoned/CMakeLists.txt
> index 5784802..0ac21e5 100644
> --- a/ktimezoned/CMakeLists.txt
> +++ b/ktimezoned/CMakeLists.txt
> @@ -7,6 +7,10 @@ endif (WIN32)
>  kservice_desktop_to_json(ktimezoned.desktop)
> 
>  add_library(kded_ktimezoned MODULE ${kded_ktimezoned_SRCS})
> +target_include_directories(kded_ktimezoned
> +  PRIVATE
> +    $<TARGET_PROPERTY:KF5::KDE4Support,INTERFACE_INCLUDE_DIRECTORIES>
> +)

This would have to be done in each and every subdirectory - urgh.

How about add this in include_directories at the toplevel of
kde-runtime/CMakeLists.txt for now?

But if you don't like either of my short-term solutions for getting rid of 
find_package(KDELibs4) (and then KDELibs4Config.cmake itself), then let's not 
change anything until the installation of forwarding headers into the right 
directories is implemented.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5