Review Request 114076: Set KDE4_INCLUDES in KDE4SupportConfig

[Stephen Kelly]

David Faure wrote:

> On Sunday 24 November 2013 23:11:25 Stephen Kelly wrote:
>> David Faure wrote:
>> > It doesn't link to kde4support, and KConfigCore doesn't install
>> > forwarding headers yet. So this is a temporary measure, the real fix
>> > being to generate and install forwarding headers; but this fix allows
>> > to move the two things forward independently.
>> 
>> Given the issues that I pointed out in the patch, a better solution might
>> be this:
>> 
>> diff --git a/ktimezoned/CMakeLists.txt b/ktimezoned/CMakeLists.txt
>> index 5784802..0ac21e5 100644
>> --- a/ktimezoned/CMakeLists.txt
>> +++ b/ktimezoned/CMakeLists.txt
>> @@ -7,6 +7,10 @@ endif (WIN32)
>>  kservice_desktop_to_json(ktimezoned.desktop)
>> 
>>  add_library(kded_ktimezoned MODULE ${kded_ktimezoned_SRCS})
>> +target_include_directories(kded_ktimezoned
>> +  PRIVATE
>> +    $<TARGET_PROPERTY:KF5::KDE4Support,INTERFACE_INCLUDE_DIRECTORIES>
>> +)
> 
> This would have to be done in each and every subdirectory - urgh.

According to my test, it is only needed in ktimezoned?

> 
> How about add this in include_directories at the toplevel of
> kde-runtime/CMakeLists.txt for now?

Yes, that also would work, I think (though I didn't try it):

 include_directories($<TARGET_PROPERTY:KF5::KDE4Support,INTERFACE_INCLUDE_DIRECTORIES>)

Thanks,

Steve.