Review Request 114076: Set KDE4_INCLUDES in KDE4SupportConfig

Stephen Kelly steveire at gmail.com
Sun Nov 24 22:11:25 UTC 2013


David Faure wrote:

> It doesn't link to kde4support, and KConfigCore doesn't install forwarding
> headers yet. So this is a temporary measure, the real fix being to
> generate and install forwarding headers; but this fix allows to move the
> two things forward independently.

Given the issues that I pointed out in the patch, a better solution might be 
this:

diff --git a/ktimezoned/CMakeLists.txt b/ktimezoned/CMakeLists.txt
index 5784802..0ac21e5 100644
--- a/ktimezoned/CMakeLists.txt
+++ b/ktimezoned/CMakeLists.txt
@@ -7,6 +7,10 @@ endif (WIN32)
 kservice_desktop_to_json(ktimezoned.desktop)
 
 add_library(kded_ktimezoned MODULE ${kded_ktimezoned_SRCS})
+target_include_directories(kded_ktimezoned
+  PRIVATE
+    $<TARGET_PROPERTY:KF5::KDE4Support,INTERFACE_INCLUDE_DIRECTORIES>
+)
 

Thanks,

Steve.




More information about the Kde-frameworks-devel mailing list